Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bypass retryablehttp library error #22

Merged
merged 1 commit into from
Jan 13, 2020
Merged

Conversation

orodeh
Copy link
Contributor

@orodeh orodeh commented Jan 13, 2020

The retryablehttp library has an error when trying to perform http PUT of an empty array. This happens when creating empty files on AWS, because we need to have one part, which has to be empty.

The fix is to use the underlying golang http library in this case. Ultimately, I would like to get rid of the retryablehttp library altogether.

Copy link
Contributor

@geetduggal geetduggal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@orodeh orodeh merged commit ceaa5ac into master Jan 13, 2020
@orodeh orodeh deleted the retryablehttp_error_bypass branch January 13, 2020 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants