Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI actions are 'successful' despite failing and produce incomplete artifacts #86

Closed
mitchcapper opened this issue Apr 26, 2022 · 1 comment · Fixed by #103
Closed

CI actions are 'successful' despite failing and produce incomplete artifacts #86

mitchcapper opened this issue Apr 26, 2022 · 1 comment · Fixed by #103
Milestone

Comments

@mitchcapper
Copy link

As long as there is any file in the .NET x86/64 and framework output directories it is considered a build success. As that folder is populated incrementally this leads to failed builds passing. It also generates artifacts with missing files (as not everything compiled).

The fail check is:
https://github.com/dnSpyEx/dnSpy/blob/master/.github/workflows/build.yml#L45

and a sample failed build: https://github.com/dnSpyEx/dnSpy/actions/runs/2189103079

@ElektroKill
Copy link
Member

ElektroKill commented Apr 29, 2022

Hi, thanks for bringing this to my attention. I had no clue such a problem existed since I almost never use the builds provided by the CI myself, especially for the ILSpy v7 port branch. To be completely honest, the CI workflow was made by the previous developer of dnSpy and I have not touched it much due to my very limited experience with GitHub Actions and PowerShell scripts. If you have a potential solution in mind feel free to open a PR to the master branch to get this fixed, if you don't then I will probably do it later this week if I find the time for it (it's holiday time here in Poland and I won't be home for the majority of the week).

mitchcapper added a commit to mitchcapper/dnSpy that referenced this issue Jul 12, 2022
mitchcapper added a commit to mitchcapper/dnSpy that referenced this issue Jul 12, 2022
…iguration

Fixes dnSpyEx#86
Build script will also throw error now if invalid arch specified.
mitchcapper added a commit to mitchcapper/dnSpy that referenced this issue Jul 12, 2022
Fixes dnSpyEx#86
Switch to matrix use to simplify build and speed up process
mitchcapper added a commit to mitchcapper/dnSpy that referenced this issue Jul 18, 2022
Fixes dnSpyEx#86
Switch to matrix use to simplify build and speed up process
@ElektroKill ElektroKill added this to the vNext milestone Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants