Update udp_server to check for bad key in json #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vkuznet I think that I cannot add reviewers for this PR, but I would like to add the people mentioned in my description. Maybe you would be able to help? EDIT: I do not have permission to merge, so I thought that official approval from the reviewer might help. |
vkuznet
requested changes
Jun 22, 2023
vkuznet
approved these changes
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was noticed that sending the messages to AMQ with a key named
typewasn't allowing the messages to be saved. For this reason we want to check for this invalid key and rename it.More on this can be read on Jira ticket CMSMONIT-554 and GitHub issue here.
FYI @leggerf @brij01 @vkuznet