Adds output module validation to Express and PromptReco workflows #11175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins results:
|
amaltaro
reviewed
Jun 9, 2022
|
|
||
| Validation of output module names in the workflow | ||
| """ | ||
| validateOutputModules(workload) |
There was a problem hiding this comment.
I would suggest to move it to the super class (StdBase). Similar to how we approach this validation validateConfigCacheExists
| """ | ||
| Makes sure all output modules comply with DBS restrictions | ||
| """ | ||
| for task in workload.getAllTasks(): |
There was a problem hiding this comment.
we should probably define cpuOnly=True, to avoid parsing Cleanup and LogCollect jobs.
|
@germanfgv German, please let me know if you need any input on this. |
|
Can one of the admins verify this patch? |
germanfgv
force-pushed
the
validateSkims
branch
from
4fc02ab to
4a27d0a
Compare
|
Jenkins results:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11171
Status
not-tested
Description
Adds output module validation for T0 workflows
Is it backward compatible (if not, which system it affects?)
YES
Related PRs
None
External dependencies / deployment changes
None