Dashboard exporter go #244
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikodemas
force-pushed
the
dashboard_exporter_go
branch
from
3f979c3
to
52f59cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@leggerf @brij01 I have created initial conversion of a
grafana-backupscript from Python to Go, but in my opinion it feels like an overkill. It is a very simple script that doesn't really cause any trouble and doesn't require efficiency, but moving to Go requires a separate GitHub workflow, separate Docker image (see dmwm/CMSKubernetes#1423) and it almost doubles the number of lines in the main script.If you are fine with it, I would like not to merge this PR and keep the existing Python version.