Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

moves amq sender code to core repo #242

Merged
merged 2 commits into from
Oct 6, 2023
Merged

moves amq sender code to core repo #242

merged 2 commits into from
Oct 6, 2023

Conversation

Panos512
Copy link
Contributor

@Panos512 Panos512 commented Oct 5, 2023

No description provided.

@nikodemas
Copy link
Member

@leggerf @brij01 Panos was doing some monitoring stuff and noticed that we are repeating some bits more than once (here and here) and decided to refactor this. Let us know if you think that these functions should be put somewhere else.

leggerf
leggerf approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@leggerf leggerf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes sense. Tnx @Panos512

@nikodemas nikodemas merged commit b70c4b6 into dmwm:master Oct 6, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leggerf leggerf leggerf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Panos512 @nikodemas @leggerf