fix: "index out of bounds" on antialiasing check #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmtrKovalenko
approved these changes
Jun 2, 2021
dmtrKovalenko
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found an issue with the antialiasing check while running one of our test-suites with osnap.
If the "comp" image is 1px smaller than the original and there happens to be an antialiasing check right on the edge, we are running out of the bounds of the image.
I managed to reproduce it reliably and implemented a test and fix for it 🙂
It's a little hard to see, because of the whitespace changes, but it is pretty much only a bounds check inside
hasManySiblingsWithSameColor.