Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Return diffCount and diffPercentage in nodejs bindings #32

Merged
merged 6 commits into from
Apr 20, 2021

Conversation

dmtrKovalenko
Copy link
Owner

  • A new flag (will likely be using only by us) --parsable-stdout that emits easy to parse output.
  • Update nodejs bindings to parse this output and return as a result
  • Add nodejs bindings tests which behave more like complete e2e because running binary

@dmtrKovalenko dmtrKovalenko changed the title feat: Return diffCount and diffPercentage into nodejs env feat: Return diffCount and diffPercentage in nodejs bindings Apr 18, 2021
bin/Print.re Outdated Show resolved Hide resolved
bin/node-bindings/odiff.js Show resolved Hide resolved
bin/node-bindings/odiff.js Outdated Show resolved Hide resolved
bin/node-bindings/odiff.js Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
dmtrKovalenko and others added 4 commits April 19, 2021 22:57
Co-authored-by: Torben Ewert <Torben@eWert-Online.com>
Co-authored-by: Torben Ewert <Torben@eWert-Online.com>
@dmtrKovalenko dmtrKovalenko merged commit 08e6bda into main Apr 20, 2021
@dmtrKovalenko dmtrKovalenko deleted the feat/node-info-parsing branch April 20, 2021 04:21
dmtrKovalenko added a commit that referenced this pull request Apr 23, 2021
* Split into multiple opam files

* generate packages with dune-project

* set "use_standard_c_and_cxx_flags" to false

* fix public name of bin

* Add opam release github action

* ci: checkout project sources before releasing

* ci: fetch tags

* Add synopsis

* Setup user and token

* Remove --dry-run

* feat: Return diffCount and diffPercentage in nodejs bindings (#32)

* Implement parsing results output for node bindings

* Update ts typings

* Use pattern matching over union

Co-authored-by: Torben Ewert <Torben@eWert-Online.com>

* Better error message

Co-authored-by: Torben Ewert <Torben@eWert-Online.com>

* Better error handling

* Add more tests and format package.json

Co-authored-by: Torben Ewert <Torben@eWert-Online.com>

* Bump version

* Update ts

* Split into multiple opam files

* generate packages with dune-project

* set "use_standard_c_and_cxx_flags" to false

* fix public name of bin

* Add opam release github action

* ci: checkout project sources before releasing

* ci: fetch tags

* Add synopsis

* Setup user and token

* Remove --dry-run

* ci: Update token location

* ci: try cloning opam repo

* Delete release-opam.yml

investigate automatic releases on a separate branch

Co-authored-by: Dmitriy Kovalenko <dmtr.kovalenko@outlook.com>
dmtrKovalenko added a commit that referenced this pull request May 22, 2021
* Add basic antialiasing support

* Remove cache

* Update tests / add tests

* Add antialiasing flag

* fix: remove rewritePrefix (#30)

Releases configured with `"esy.release.rewritePrefix": true` cannot be installed into deep filesystem locations (the limit is around 108 characters).

* Clip antialiasing check to correct dimensions

* feat: Return diffCount and diffPercentage in nodejs bindings (#32)

* Implement parsing results output for node bindings

* Update ts typings

* Use pattern matching over union

Co-authored-by: Torben Ewert <Torben@eWert-Online.com>

* Better error message

Co-authored-by: Torben Ewert <Torben@eWert-Online.com>

* Better error handling

* Add more tests and format package.json

Co-authored-by: Torben Ewert <Torben@eWert-Online.com>

* Bump version

* Update ts

* chore: Split code into multiple opam packages (#28) (#31)

* Split into multiple opam files

* generate packages with dune-project

* set "use_standard_c_and_cxx_flags" to false

* fix public name of bin

* Add opam release github action

* ci: checkout project sources before releasing

* ci: fetch tags

* Add synopsis

* Setup user and token

* Remove --dry-run

* feat: Return diffCount and diffPercentage in nodejs bindings (#32)

* Implement parsing results output for node bindings

* Update ts typings

* Use pattern matching over union

Co-authored-by: Torben Ewert <Torben@eWert-Online.com>

* Better error message

Co-authored-by: Torben Ewert <Torben@eWert-Online.com>

* Better error handling

* Add more tests and format package.json

Co-authored-by: Torben Ewert <Torben@eWert-Online.com>

* Bump version

* Update ts

* Split into multiple opam files

* generate packages with dune-project

* set "use_standard_c_and_cxx_flags" to false

* fix public name of bin

* Add opam release github action

* ci: checkout project sources before releasing

* ci: fetch tags

* Add synopsis

* Setup user and token

* Remove --dry-run

* ci: Update token location

* ci: try cloning opam repo

* Delete release-opam.yml

investigate automatic releases on a separate branch

Co-authored-by: Dmitriy Kovalenko <dmtr.kovalenko@outlook.com>

* Add basic antialiasing support

* Remove cache

* Update tests / add tests

* Add antialiasing flag

* Clip antialiasing check to correct dimensions

* Fix tests

* Make bigarray-first IO version

* WIP: add comparing debuggers

* Commit test file

* Fix compilation

* Implement flat bigarray based architecture for antialsing

* Fix antialiasing with --diff-mask

* More precise type checking for rowPointers fields

* switch to 32bit bigarray

Co-authored-by: Dmitriy Kovalenko <dmtr.kovalenko@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants