Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sqlqueryreceiver) add error count metrics for receiver #4

Conversation

kasia-kujawa
Copy link
Collaborator

Format of metric:

# HELP otelcol_receiver_error_count Number of errors
# TYPE otelcol_receiver_error_count counter
otelcol_receiver_error_count{error_type="collect_error",query="query-0: select * from simple_logs",receiver="sqlquery",service_instance_id="9763b7d6-e907-438f-9b70-6e4882756785",service_name="otelcol-sumo",service_version="v0.70.0-sumo-0-198-g210a3dfb53"} 0
otelcol_receiver_error_count{error_type="collect_error",query="query-0: select * from test_logs",receiver="sqlquery/wrong_query",service_instance_id="9763b7d6-e907-438f-9b70-6e4882756785",service_name="otelcol-sumo",service_version="v0.70.0-sumo-0-198-g210a3dfb53"} 2
otelcol_receiver_error_count{error_type="start_error",query="query-0: select * from simple_logs",receiver="sqlquery",service_instance_id="9763b7d6-e907-438f-9b70-6e4882756785",service_name="otelcol-sumo",service_version="v0.70.0-sumo-0-198-g210a3dfb53"} 0
otelcol_receiver_error_count{error_type="start_error",query="query-0: select * from test_logs",receiver="sqlquery/wrong_query",service_instance_id="9763b7d6-e907-438f-9b70-6e4882756785",service_name="otelcol-sumo",service_version="v0.70.0-sumo-0-198-g210a3dfb53"} 0

for configuration:

receivers:
  sqlquery:
    collection_interval: 10s
    driver: postgres
    datasource: "host=127.0.0.1 port=5432 user=otel password=otel sslmode=disable"
    queries:
      - sql: "select * from simple_logs"
        logs:
        - body_column: BODY

  sqlquery/wrong_query:
    collection_interval: 10s
    driver: postgres
    datasource: "host=127.0.0.1 port=5432 user=otel password=otel sslmode=disable"
    queries:
      - sql: "select * from test_logs"
        logs:
        - body_column: BODY
exporters:
  logging:
    verbosity: detailed
    sampling_initial: 5
    sampling_thereafter: 200

service:
  telemetry:
      logs:
        level: "debug"
  pipelines:
    logs:
      receivers:
        - sqlquery
      exporters:
        - logging
    logs/wrong_query:
      receivers:
        - sqlquery/wrong_query
      exporters:
        - logging

@andrzej-stencel
Copy link
Collaborator

Is the _count suffix in the metric name right? I'm not sure I've seen it in other OpenTelemetry metrics.

@kasia-kujawa
Copy link
Collaborator Author

Suffix removed, new format of metric:

# HELP otelcol_receiver_errors Number of errors
# TYPE otelcol_receiver_errors counter
otelcol_receiver_errors{error_type="collect_error",query="query-0: select * from simple_logs",receiver="sqlquery",service_instance_id="f5884777-cec4-48a0-8b9c-834562e91acb",service_name="otelcol-sumo",service_version="v0.70.0-sumo-0-204-gdbf1aff740"} 0
otelcol_receiver_errors{error_type="start_error",query="query-0: select * from simple_logs",receiver="sqlquery",service_instance_id="f5884777-cec4-48a0-8b9c-834562e91acb",service_name="otelcol-sumo",service_version="v0.70.0-sumo-0-204-gdbf1aff740"} 0

@kasia-kujawa kasia-kujawa merged commit a63f68b into dmolenda-sumo:sqlquery-receiver-add-logs May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants