-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(feel): verify non-existing member access #541
Conversation
ddc331f
to
91ed70f
Compare
b99bf6f
to
ea6c3a5
Compare
@dmn-tck/contributors please review |
Thank you for the tests. They look correct to me. However, there are only 6 test cases that test the selection for lists and contexts. I recommend moving the tests for lists (4) in 0069-feel-list and the ones for context (2) in 0057-feel-context. It will make our life easier when designing new tests to improve the coverage - have tests for sections 10.3.2.5 Lists and filters and 10.3.2.6 Context in only two separate files. Also, move the expected values where they belong, in the .xml file not in the dmn file. The expected value can be mentioned in a comment in the dmn file. I believe @StrayAlien used this pattern in lots of our test cases. |
Hi @nikku, could you please check the last comment from @opatrascoiu? |
@baldimir Thanks for the reminder. This is on my TODO-list. I just was not able to get into it. |
@opatrascoiu to verify I understand you correctly:
|
@nikku Regarding the test patterns: For example, it is recommended to have test cases related to a certain behaviour (e.g. a certain function, class) in the same place (e.g. file). Please move the new tests related to lists (e.g. filters) to 0069-feel-list and the ones related to contexts (e.g. path navigation) in 0057-feel-context. Thank you. |
ea6c3a5
to
7def45c
Compare
@opatrascoiu I updated this PR, moving the tests around as you suggested. Please have another look. |
@nikku Apologies for the delay. Thank you very much for the contribution. The tests look good to me. |
Ensures the following is true:
Related to #537