New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Utilities and cleanups for socket. #9576

Merged

trivialfis merged 2 commits into dmlc:master from trivialfis:cleanup-socket

Sep 13, 2023

Member

trivialfis commented Sep 13, 2023

Use c++-17 nodiscard and nested ns.
Add bind method to socket.
Remove rabit parameters.


          Utilities and cleanups for socket.

c41f01a

- Use c++-17 nodiscard and nested ns.
- Add bind method to socket.

Member Author

trivialfis commented Sep 13, 2023


          windows.

cfc7e41

rongou approved these changes

View reviewed changes

trivialfis merged commit b438d68 into dmlc:master

trivialfis deleted the cleanup-socket branch

September 13, 2023 17:41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet