Unify the hist tree method for different devices. #9363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hcho3
reviewed
Jul 10, 2023
Comment on lines
+14
to
+22
| auto msg = | ||
| "The tree method `gpu_hist` is deprecated since 2.0.0. To use GPU training, set the `device` " | ||
| R"(parameter to CUDA instead. | ||
|
|
||
| E.g. tree_method = "hist", device = "CUDA" | ||
|
|
||
| )"; | ||
| LOG(WARNING) << msg; | ||
| logged = true; |
There was a problem hiding this comment.
Does the device parameter exist already? Then why do the C++ tests use gpu_id ?
There was a problem hiding this comment.
Not yet, it's in this PR: #9362 . It's difficult to split up the changes without referencing each other.
There was a problem hiding this comment.
Got it. Let me approve this PR for now.
hcho3
approved these changes
Jul 11, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gpu_hist.