-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support min_delta
in early stopping.
#7137
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7137 +/- ##
=======================================
Coverage 82.19% 82.19%
=======================================
Files 13 13
Lines 3999 3999
=======================================
Hits 3287 3287
Misses 712 712
Continue to review full report at Codecov.
|
@trivialfis I'm not sure why we need to have both It will be useful to rename parameter Also, looking into APIs of early stopping callbacks from other frameworks (for example, pytorch-lightning and tensorflow), I see only one parameter |
My initial thought is just to allow some turbulence in validation results during training. If that's not useful and doesn't make sense I can remove the |
Your argument make sense to me. Will follow up with the removal. |
Removed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think everything is fine now. Thank you!
Close #7136 .
Close #7066 .