Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new train_folds parameter #5114

Merged
merged 1 commit into from
Dec 19, 2019

Conversation

trivialfis
Copy link
Member

Continue #5064 .

@trivialfis
Copy link
Member Author

@pommedeterresautee Could you please help taking a look? See the linked PR for context. ;-)

Copy link
Member

@pommedeterresautee pommedeterresautee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the change makes sense and works.

@pommedeterresautee pommedeterresautee merged commit e521bb6 into dmlc:master Dec 19, 2019
trivialfis added a commit that referenced this pull request Dec 19, 2019
@trivialfis
Copy link
Member Author

Oh no ... The author is changed by github.

@iblumin
Copy link

iblumin commented Dec 30, 2019

That's alright! I've never made an open source contribution before and didn't have time this last month to figure out why this was failing. Thanks for pushing this through! @trivialfis @pommedeterresautee

@trivialfis trivialfis deleted the iblumin-master branch January 28, 2020 19:16
@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants