Ensure that pip check does not fail due to bad platform tag
#10755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hcho3
changed the title
pip check does not fail due to bad platform tag
hcho3
commented
Aug 26, 2024
|
@lorepirri Can I get a review for this fix? |
3 tasks
jakirkham
reviewed
Aug 27, 2024
Co-authored-by: jakirkham <jakirkham@gmail.com>
jakirkham
reviewed
Aug 27, 2024
| - "nvidia-nccl-cu12 ; platform_system == 'Linux' and platform_machine != 'aarch64'" | ||
| + "scipy" | ||
| "scipy", | ||
| - "nvidia-nccl-cu12 ; platform_system == 'Linux' and platform_machine != 'aarch64'", |
There was a problem hiding this comment.
As a note to reviewers, GitHub PR diffs of patches can look confusing
Would recommend looking at the patch on Hyunsu's fork (also included below)
This is just dropping the nvidia-nccl-cu12 line
diff --git python-package/pyproject.toml python-package/pyproject.toml
index 20d3f9974..953087ff4 100644
--- python-package/pyproject.toml
+++ python-package/pyproject.toml
@@ -30,7 +30,6 @@ classifiers = [
dependencies = [
"numpy",
"scipy",
- "nvidia-nccl-cu12 ; platform_system == 'Linux' and platform_machine != 'aarch64'",
]
[project.urls]
jakirkham
approved these changes
Aug 27, 2024
5 tasks
trivialfis
pushed a commit
to trivialfis/xgboost
that referenced
this pull request
Oct 16, 2024
…0755) * Remove custom tag generation * Revert "Remove custom tag generation" This reverts commit fe3cf0e. * Fetch an accurate platform tag from Pip 22+ * Fix formatting * TOML allows trailing commas * Update patch * Add trailing comma * Fix up patch * Use `packaging` Co-authored-by: jakirkham <jakirkham@gmail.com> --------- Co-authored-by: jakirkham <jakirkham@gmail.com>
trivialfis
added a commit
that referenced
this pull request
Oct 17, 2024
#10902) --------- Co-authored-by: Philip Hyunsu Cho <chohyu01@cs.washington.edu> Co-authored-by: jakirkham <jakirkham@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10705
sysconfig.get_platformdoes not report an accurate platform tag; to use a correct platform tag, usepip.