Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial fix for CTK 12.5 #10574

Merged
merged 3 commits into from
Jul 16, 2024
Merged

Partial fix for CTK 12.5 #10574

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dd34a8b
Partial fix for CTK 12.5
trivialfis Jul 12, 2024
c833a94
Fix.
trivialfis Jul 12, 2024
4694268
Merge branch 'master' into fix-ctk-125
trivialfis Jul 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 8 additions & 13 deletions src/tree/updater_gpu_common.cuh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,13 @@
/*!
* Copyright 2017-2019 XGBoost contributors
/**
* Copyright 2017-2024, XGBoost contributors
*/
#pragma once
#include <thrust/random.h>
#include <cstdio>
#include <cub/cub.cuh>
#include <stdexcept>
#include <string>
#include <vector>
#include "../common/categorical.h"
#include "../common/device_helpers.cuh"
#include "../common/random.h"
#include <limits> // for numeric_limits
#include <ostream> // for ostream

#include "gpu_hist/histogram.cuh"
#include "param.h"
#include "xgboost/base.h"

namespace xgboost::tree {
struct GPUTrainingParam {
Expand Down Expand Up @@ -54,8 +49,8 @@ enum DefaultDirection {
};

struct DeviceSplitCandidate {
float loss_chg {-FLT_MAX};
DefaultDirection dir {kLeftDir};
float loss_chg{-std::numeric_limits<float>::max()};
DefaultDirection dir{kLeftDir};
int findex {-1};
float fvalue {0};
// categorical split, either it's the split category for OHE or the threshold for partition-based
Expand Down
1 change: 1 addition & 0 deletions src/tree/updater_gpu_hist.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
#include "../common/cuda_context.cuh" // CUDAContext
#include "../common/device_helpers.cuh"
#include "../common/hist_util.h"
#include "../common/random.h" // for ColumnSampler, GlobalRandom
#include "../common/timer.h"
#include "../data/ellpack_page.cuh"
#include "../data/ellpack_page.h"
Expand Down
Loading