This repository has been archived by the owner on Jan 15, 2024. It is now read-only.
[API] Try to use the new None feature in MXNet + Drop support for MXNet 1.5 #967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #967 +/- ##
==========================================
- Coverage 90.78% 90.05% -0.73%
==========================================
Files 67 67
Lines 6423 6386 -37
==========================================
- Hits 5831 5751 -80
- Misses 592 635 +43
|
szhengac
approved these changes
Oct 10, 2019
sxjscience
changed the title
sxjscience
changed the title
sxjscience
changed the title
fix fix fix remove all hack try to remove all hack remove print
Disable tests with MXNet 1.5 completely Instead of running tests for nightly version twice Try fix 'Inline literal start-string without end-string' error Revert "Try fix 'Inline literal start-string without end-string' error" This reverts commit b3b9e66. Fix gpu_doc exit code Improve the fix Fix syntax Escape $ Don't escape { Revert "Don't escape {" This reverts commit 976d455. Revert "Escape $" This reverts commit 9fd9e54. Revert "Fix syntax" This reverts commit 4ba73f6. Revert "Improve the fix" This reverts commit f62b817. Revert "Fix gpu_doc exit code" This reverts commit 0a3080e.
sxjscience
force-pushed
the
none_refactor
branch
from
00766aa
to
c1e72d0
Compare
|
Job PR-967/19 is complete. |
try to fix
sxjscience
force-pushed
the
none_refactor
branch
from
13a35e6
to
bfe9600
Compare
|
Job PR-967/20 is complete. |
|
Find that the SimVerb (test_simverb3500) is still not available, should we exclude it or upload it into S3? |
|
Job PR-967/21 is complete. |
We need to create one... I do not know how to do that though |
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since we have supported None in HybridBlock of Gluon (apache/mxnet#16280), remove all the hacks.
The change will force GluonNLP to rely on the nightly-build of MXNet.
Checklist
Essentials
Comments
cc @dmlc/gluon-nlp-team