Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

[FEATURE] Add length normalized metrics for machine translation tasks #1095

Merged
merged 7 commits into from
Jan 22, 2020

Conversation

liuzh47
Copy link
Contributor

@liuzh47 liuzh47 commented Jan 6, 2020

Description

  • Add length normalized loss metric for machine translation task.
  • Test cases are included for the new metrics.
  • Remove Gluonnlp EvalMetric class

Fixes #1094

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

@liuzh47 liuzh47 requested a review from a team as a code owner January 6, 2020 09:26
@codecov
Copy link

codecov bot commented Jan 6, 2020

Codecov Report

Merging #1095 into master will increase coverage by 0.44%.
The diff coverage is 90.9%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1095      +/-   ##
=========================================
+ Coverage   88.26%   88.7%   +0.44%     
=========================================
  Files          67      68       +1     
  Lines        6312    6285      -27     
=========================================
+ Hits         5571    5575       +4     
+ Misses        741     710      -31
Impacted Files Coverage Δ
src/gluonnlp/metric/__init__.py 100% <100%> (ø) ⬆️
src/gluonnlp/metric/masked_accuracy.py 100% <100%> (+39.53%) ⬆️
src/gluonnlp/metric/length_normalized_loss.py 89.28% <89.28%> (ø)

@leezu
Copy link
Contributor

leezu commented Jan 6, 2020

Please merge master due to #1096

@mli
Copy link
Member

mli commented Jan 7, 2020

Job PR-1095/4 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-1095/4/index.html

@mli
Copy link
Member

mli commented Jan 10, 2020

Job PR-1095/5 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-1095/5/index.html

@mli
Copy link
Member

mli commented Jan 10, 2020

Job PR-1095/6 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-1095/6/index.html

@leezu leezu self-requested a review January 11, 2020 09:59
@leezu leezu added the release focus Progress focus for release label Jan 15, 2020
@mli
Copy link
Member

mli commented Jan 16, 2020

Job PR-1095/7 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-1095/7/index.html

@mli
Copy link
Member

mli commented Jan 16, 2020

Job PR-1095/8 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-1095/8/index.html

@leezu leezu merged commit c5cbaad into dmlc:master Jan 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release focus Progress focus for release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants