Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin mxnet version in response to mx.metric reorg #1310

Merged
merged 4 commits into from
May 21, 2020

Conversation

zhreshold
Copy link
Member

FYI mx.metric is replaced by mx.gluon.metric in mxnet 2.0

@mli
Copy link
Member

mli commented May 20, 2020

Job PR-1310-1 is done.
Docs are uploaded to http://gluon-vision-staging.s3-website-us-west-2.amazonaws.com/PR-1310/1/index.html
Code coverage of this PR: pr.svg vs. Master: master.svg

@zhreshold
Copy link
Member Author

@dmlc/gluon-nlp-committers

# pylint: disable=unused-import
from mxnet import metric
except ImportError:
from mxnet.gluon import metric
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are API changes besides the rename: apache/mxnet#18046

@zhreshold
Copy link
Member Author

@leezu What's nlp's solution in terms of the transition from 1.0 to 2.0 at this time?

@sxjscience
Copy link
Member

@zhreshold Currently, we are improving lots of APIs. The new numpy version will rely on MXNet 2.0 only and will not be compatible to the old version: dmlc/gluon-nlp#1225

@zhreshold
Copy link
Member Author

@sxjscience So you will pin the mxnet to be <2.0 for non-numpy gluonnlp?

@sxjscience
Copy link
Member

@zhreshold Yes, I think it will depend on MXNet 1.7. Also @dmlc/gluon-nlp-committers , please correct me if I'm wrong.

@zhreshold
Copy link
Member Author

@dmlc/gluon-cv-committers @dmlc/gluon-cv-reviewer GluonCV hasn't started transition to either numpy or mxnet 2.0 so the choice will be

  • Maintain compatibility 1.x/2.0, good news is that I have tested that current metric usage is not affected by API but only namespace change
  • Drop mxnet 2.0 support for gluoncv master
    Any opinion?

@szha
Copy link
Member

szha commented May 20, 2020

the cost of committing to backward compatibility for 2.0 is too high and infeasible. I think proper versioning should be used to freeze gluoncv to 1.x until the transition happens.

@bryanyzhu
Copy link
Collaborator

Agree with szha@ and sxjscience@, it is easier to just pin the version to 1.x before the transition is fully ready.

@zhreshold zhreshold changed the title Back import mx.metric Pin mxnet version in response to mx.metric reorg May 21, 2020
@mli
Copy link
Member

mli commented May 21, 2020

Job PR-1310-5 is done.
Docs are uploaded to http://gluon-vision-staging.s3-website-us-west-2.amazonaws.com/PR-1310/5/index.html
Code coverage of this PR: pr.svg vs. Master: master.svg

@zhreshold zhreshold merged commit 2b6f382 into dmlc:master May 21, 2020
@zhreshold zhreshold deleted the fix-mxnet-2-metric branch May 21, 2020 23:32
chongruo pushed a commit to chongruo/gluon-cv that referenced this pull request May 26, 2020
* mx.metric

* pin version

* fix lint

* reduce parallel test iter/bs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants