Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy treatment on 0-size arrays from Python docs #133

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Copy treatment on 0-size arrays from Python docs #133

merged 1 commit into from
Dec 13, 2023

Conversation

leofang
Copy link
Contributor

@leofang leofang commented Dec 11, 2023

To make the C & Python docs in sync, as suggested in apache/arrow#38472 (comment). cc: @pitrou @rgommers

@leofang leofang mentioned this pull request Dec 11, 2023
Merged
rgommers
rgommers approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this @leofang

kkraus14
kkraus14 approved these changes Dec 12, 2023
View reviewed changes
Copy link

@kkraus14 kkraus14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @leofang

@tqchen tqchen merged commit 2a7e9f1 into dmlc:main Dec 13, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkraus14 kkraus14 kkraus14 approved these changes

@pitrou pitrou pitrou approved these changes

@rgommers rgommers rgommers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@leofang @rgommers @pitrou @kkraus14 @tqchen