[Feature] FindEdge/FindEdges for Immutable Graph #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Works fine with Transformer. |
|
@zheng-da EdgeSubgraph finished. |
zheng-da
reviewed
Feb 25, 2019
26 tasks
zheng-da
reviewed
Feb 26, 2019
| std::vector<int64_t> *indptr, | ||
| std::vector<dgl_id_t> *indices, | ||
| std::vector<dgl_id_t> *edge_ids, | ||
| bool in_csr); |
There was a problem hiding this comment.
can you make the input arguments const reference? input pointers usually mean the vectors will be modified by the method.
|
everything else looks good. |
zheng-da
approved these changes
Feb 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
FindEdge(s) and EdgeSubgraph have not been implemented in Immutable Graph. #369
Checklist
Please feel free to remove inapplicable items for your PR.
or have been fixed to be compatible with this change
Changes
EdgeListstructure inImmutableGraph, and a shared pointer attributeedge_list_; to avoid unnecessary memory cost,edge_list_is created when it's required.EdgeSubgraphEdgeSubgraph, but I was too lazy and I would finish it soon.