Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Transform] Modules for Augmentation #3668

Merged
merged 53 commits into from
Jan 25, 2022
Merged

[Transform] Modules for Augmentation #3668

merged 53 commits into from
Jan 25, 2022

Conversation

mufeili
Copy link
Member

@mufeili mufeili commented Jan 20, 2022

Description

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented
  • To the best of my knowledge, examples are either not affected by this change,
    or have been fixed to be compatible with this change
  • Related issue is referred in this PR
  • If the PR is for a new model/paper, I've updated the example index here.

@mufeili mufeili requested a review from jermainewang January 20, 2022 07:50
@dgl-bot
Copy link
Collaborator

dgl-bot commented Jan 20, 2022

To trigger regression tests:

  • @dgl-bot run [instance-type] [which tests] [compare-with-branch];
    For example: @dgl-bot run g4dn.4xlarge all dmlc/master or @dgl-bot run c5.9xlarge kernel,api dmlc/master

python/dgl/transform/module.py Outdated Show resolved Hide resolved
python/dgl/transform/module.py Outdated Show resolved Hide resolved
python/dgl/transform/module.py Show resolved Hide resolved
python/dgl/transform/module.py Show resolved Hide resolved
python/dgl/transform/module.py Show resolved Hide resolved
python/dgl/transform/module.py Show resolved Hide resolved
python/dgl/transform/module.py Outdated Show resolved Hide resolved
@mufeili
Copy link
Member Author

mufeili commented Jan 23, 2022

@VoVAllen It seems that PyTorch CI still raises an error about PyTorch version like below:

Exception: Detected an old version of PyTorch. Please update torch>=1.8.0 for the best experience.

@VoVAllen
Copy link
Collaborator

@mufeili It's on windows. Please contact @BarclayII to update the pytorch version on windows CI machine

@jermainewang
Copy link
Member

Does it mean that once this is merged, we need to update the minimal required version of PyTorch?

@mufeili
Copy link
Member Author

mufeili commented Jan 25, 2022

Does it mean that once this is merged, we need to update the minimal required version of PyTorch?

Yes, 1.8.0

@mufeili mufeili merged commit 2b98e76 into dmlc:master Jan 25, 2022
@mufeili mufeili deleted the augmentation branch January 25, 2022 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants