[BugFix] Make program thread-local to support multi-threading #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lingfanyu
force-pushed
the
fix-multigpu-program
branch
from
ef28b31 to
c378481
Compare
|
@yzh119 This PR should fix the multi-gpu issue. Can you double check? |
|
Thanks, the PR solved my problem. |
|
Lingfan, could you run treelstm on multi gpu to see the improvement?
…On Sat, Jan 5, 2019, 2:18 PM Zihao Ye ***@***.***> wrote:
Thanks, the PR solved my problem.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_dmlc_dgl_pull_338-23issuecomment-2D451683128&d=DwMCaQ&c=slrrB7dE8n7gBJbeO0g-IQ&r=TjZkSg9Jv2ODj9HXvCAcwgw9aSXPP3jh5bcRbCbUO5s&m=e_NWBIH78C4C3HHVJGYWN2YvbHbzQceYgT1zlp8P8s8&s=CYbUFKHMGqUyLc1NvpF01-6Oz3o7XvJg5jl9Q5xXz_Y&e=>,
or mute the thread
<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AD3qZTcxBWvrmRfYzx5PslxUdgLh7IWGks5vAPp2gaJpZM4ZveVR&d=DwMCaQ&c=slrrB7dE8n7gBJbeO0g-IQ&r=TjZkSg9Jv2ODj9HXvCAcwgw9aSXPP3jh5bcRbCbUO5s&m=e_NWBIH78C4C3HHVJGYWN2YvbHbzQceYgT1zlp8P8s8&s=yeGMc_gVD39y5XmEPtM99WHxNc3TpkOlaJe4dmvhd6w&e=>
.
|
|
well, i find that currently enabling multi-GPU could not speed up training, the number of active GPUs is always one during training. |
|
@yzh119 Sounds weird. When I ran your transformer on a 4-GPU instance, all GPUs were active but with low utilization (<25%). |
jermainewang
approved these changes
Jan 12, 2019
26 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
DGLGraph uses one global execution plan / program, which leads to data racing when multi-threading (like PyTorch DataParallel) is used. This PR fix this bug by making schedule a threading.local object. (#302)
Checklist
or have been fixed to be compatible with this change
Changes