[Bugfix] Fix multiple send recv #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BarclayII
reviewed
Dec 19, 2018
jermainewang
requested changes
Dec 19, 2018
python/dgl/utils.py
Outdated
| # XXX: assuming tensor supports index using slices | ||
| # cannot call tousertensor because for slice type it would | ||
| # further call tonumpy, which overwrites _pydata and causes | ||
| # future bugs... |
There was a problem hiding this comment.
Originally when I implemented get_items and set_items, I write
if isintance(index, Index):
index = index.tousertensor()
And I just found this is buggy, because, if index._pydata is a slice, index.tousertensor will can tonumpy, which overwrites _pydata. As a result, index._pydata becomes a numpy.ndarray... And this can potentially cause bugs
python/dgl/runtime/scheduler.py
Outdated
| if apply_func is not None: | ||
| schedule_apply_nodes(graph, recv_nodes, apply_func, inplace) | ||
| else: | ||
| src, dst, _ = graph._graph.find_edges(eid) |
There was a problem hiding this comment.
lingfan: Mistakenly removed your comment...
There was a problem hiding this comment.
You are right about using mask on src, dst to avoid find_edge
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #75 and other small bugs (see below) and supports multiple recv after send.
Previously, each recv call clears message graph so following recv won't see any message. This PR fix the bug by removing message graph and put message in edge space (but still in a separate message frame). Now message frame has the same size as edge frame and whether there is a message on an edge is indicated by a special "boolean" index in DGLGraph (graph._msg_index).
Now users can:
Checklist
or have been fixed to be compatible with this change
Changes