Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove old fragments #2

Merged
merged 1 commit into from
Apr 21, 2018
Merged

remove old fragments #2

merged 1 commit into from
Apr 21, 2018

Conversation

zzhang-cn
Copy link
Collaborator

No description provided.

@zzhang-cn zzhang-cn merged commit 447d16b into master Apr 21, 2018
jermainewang pushed a commit that referenced this pull request Oct 7, 2018
* Test CPP branch CI (#2)

* Fix batching node-only graphs (#62)

* fixing batching with graphs with no edges

* oops forgot test

* fix readme

* Docker and Jenkins (#1)

* docker ci cpu

* install python packages

* docker ci gpu

* add readme

* use dgl cpu image

* run command in container as root

* use python3

* fix test case

* remove nose from docker file

* docker folder readme

* parallelize cpu and gpu

* top level stages

* comment out python2 related installation

* fix

* remove igraph

* building for cpp

* change building order

* export env in test stage

* withEnv

* run docker container as root

* fix test cases

* fix test cases

* minor

* remove old build
jermainewang pushed a commit that referenced this pull request Jan 4, 2019
* reverse a graph

* Reverse a graph

* Fix

* Revert "Fix"

This reverts commit 1728826.

* Fix

* Fix

* Delete vcs.xml

* Delete Project_Default.xml

* Fix

* Fix

* Fix

* Remove outdated test

* Reorg transform and update reverse (#2)

* Reorg transform and update reverse

* Fix doc and test

* Update test

* Resolve conflict

* CI oriented fix

* Remove outdated import

* Fix import

* Fix import

* define __all__ for wildcard imports

* Fix import

* Address circular imports

* Fix

* Fix test case

* Fix

* Fix

* Remove unused import

* Fix

* Fix

* Fix
mufeili added a commit that referenced this pull request Jun 28, 2020
…_edges (#1677)

* Fix (#1)

* Update

* Fix

* Fix

* Update

* Fix

* Fix

* Fix

* Fix

* Fixg

* Fix

* Fix

* Fix

* Fix

* Fix

* Fix

* Fix

* Fix

* Add test case

* Trigger CI (#2)

* Update

* Fix

* Fix

* Update

* Fix

* Fix

* Fix

* Fix

* Fixg

* Fix

* Fix

* Fix

* Fix

* Fix

* Fix

* Fix

* Fix

* Add test case

* test

* Fix (#3)

* Update

* Fix

* Fix

* Update

* Fix

* Fix

* Fix

* Fix

* Fixg

* Fix

* Fix

* Fix

* Fix

* Fix

* Fix

* Fix

* Fix

* Add test case

* test

* Fix

* Fix

* Roll back

* Roll back

* CI

Co-authored-by: Minjie Wang <wmjlyjemaine@gmail.com>
kingmbc pushed a commit to kingmbc/dgl that referenced this pull request Aug 2, 2020
…_edges (dmlc#1677)

* Fix (dmlc#1)

* Update

* Fix

* Fix

* Update

* Fix

* Fix

* Fix

* Fix

* Fixg

* Fix

* Fix

* Fix

* Fix

* Fix

* Fix

* Fix

* Fix

* Add test case

* Trigger CI (dmlc#2)

* Update

* Fix

* Fix

* Update

* Fix

* Fix

* Fix

* Fix

* Fixg

* Fix

* Fix

* Fix

* Fix

* Fix

* Fix

* Fix

* Fix

* Add test case

* test

* Fix (dmlc#3)

* Update

* Fix

* Fix

* Update

* Fix

* Fix

* Fix

* Fix

* Fixg

* Fix

* Fix

* Fix

* Fix

* Fix

* Fix

* Fix

* Fix

* Add test case

* test

* Fix

* Fix

* Roll back

* Roll back

* CI

Co-authored-by: Minjie Wang <wmjlyjemaine@gmail.com>
GMNGeoffrey added a commit to GMNGeoffrey/dgl that referenced this pull request Jan 29, 2025
This is just the output of the hipify-inplace.sh and hipify-tensoradapter.py scripts with no further modifications, so probably you'll want to just spot-check.

I think it will be easier to review changes to the actual HIP source directly rather than trying to thing about what the hipify script will do and since there are a decent number of changes to get the build and tests working, that seems worth it. In the end we should have a bunch of hip source files and .prehip cuda files that they can be generated from. Then we can handle organization however we want: restore the originals and have hipification be part of a build process, have the hip versions on a separate branch, etc.

I put the .prehip files in a separate commit to keep things a bit cleaner.

Note that this PR is based off of dmlc#1. I didn't make that the base branch though because then it would all be in my fork.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant