Added MXNET_COMMIT env variable for upstream commit/tag #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshbode
force-pushed
the
libmxnet_commit
branch
from
f154092 to
621f0b3
Compare
Codecov Report
@@ Coverage Diff @@
## master #260 +/- ##
=======================================
Coverage 69.09% 69.09%
=======================================
Files 25 25
Lines 1877 1877
=======================================
Hits 1297 1297
Misses 580 580Continue to review full report at Codecov.
|
|
@joshbode Thanks a lot! Can you add a few sentences to the installation doc ( http://dmlc.ml/MXNet.jl/latest/user-guide/install/#Manual-Compilation-1 ) about this? |
Setting the `MXNET_COMMIT` environment variable to a tag, branch or hash will use that version of the upstream mxnet repo in building the libmxnet shared object. Additionally, the upstream submodules are cleared (and reinitialised) every build to prevent some issues when submodules make changes (squashes, etc).
joshbode
force-pushed
the
libmxnet_commit
branch
from
621f0b3 to
d431997
Compare
|
Good idea :) Done |
|
Fantastic! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting the
MXNET_COMMITenvironment variable to a tag, branch or hashwill use that version of the upstream mxnet repo in building the libmxnet
shared object.
Additionally, the upstream submodules are cleared (and reinitialised)
every build to prevent some issues when submodules make changes
(squashes, etc).