Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get Slider return value bug fixed #17

Merged
merged 9 commits into from
Jul 30, 2024

Conversation

turanheydarli
Copy link
Contributor

No description provided.

@turanheydarli
Copy link
Contributor Author

Get Slider return value bug fixed

@dmitry-ivashenko
Copy link
Owner

Hey! Thanks for your contribution. I see too many unnecessary files in the diff. Could you please leave only the valuable ones?

@turanheydarli
Copy link
Contributor Author

Hey! You're welcome. Here is the cleaned-up version. Thanks for pointing that out.

Copy link
Owner

@dmitry-ivashenko dmitry-ivashenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@turanheydarli please check my comment

@@ -4,7 +4,7 @@ MonoImporter:
externalObjects: {}
serializedVersion: 2
defaultReferences: []
executionOrder: 0
executionOrder: 8
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is it for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, Dimitry! I got some errors when initializing my screen on OnEnable and I tried to change execution order for this issue. Actually it's project spesific error and not nessesary.

package.json Outdated
"url": "https://bit.ly/dmitry_ivashenko"
}
}

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have the package.json inside Assets/Plugins/StatefulUI.
You can install the library using UPM as described in README.
Please remove it.

Copy link
Owner

@dmitry-ivashenko dmitry-ivashenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's okay now, thanks!

@dmitry-ivashenko dmitry-ivashenko merged commit 6a5e303 into dmitry-ivashenko:main Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants