Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSH config support #933

Merged
merged 2 commits into from
Nov 19, 2023
Merged

SSH config support #933

merged 2 commits into from
Nov 19, 2023

Conversation

jbeisser
Copy link

This adds native SSH configuration support, with some minor caveats:

  • It's not perfect. OpenSSH and Kevin Burke's ssh_config library behave slightly differently in compiling results. OpenSSH wants least to most specific, Burke's library wants most specific to least.
  • It's ugly, but it does work. The ssh.go dialer could use some additional love.
  • It also supports alternate ports in the SSH configuration file, but not very intelligently.

This DOES allow you to recycle configurations in the provider section, without setting a static username on the URI. So, if users are managed via PAM or LDAP access to the socket, it should just work.

@matrohon matrohon mentioned this pull request Mar 10, 2022
@jbeisser
Copy link
Author

Updated to reflect other changes in 0.7.0.

@pstrzelczak
Copy link
Contributor

@jbeisser could you resolve conflicts here? @dmacvicar it is cumbersome to be forced to pass extra parameters to uri.

@dmacvicar dmacvicar merged commit 9adc252 into dmacvicar:main Nov 19, 2023
4 checks passed
@dmacvicar
Copy link
Owner

thanks 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants