Examples update #927
Merged
Examples update #927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed no longer required filesystem line
Update to refelct CoreOS name change
|
Thanks! 🥳 |
dmacvicar
pushed a commit
to jimnydev/terraform-provider-libvirt
that referenced
this pull request
Sep 28, 2024
* Start work of making Fedora CoreOS example out of the old CoreOS one * Update mounting for QEMU agent to use /var since /mnt is a synlink in fcos * Bump version of dmacvicar/libvirt to latest * Switch ignition provider to get configspec Fedora CoreOS wants Removed no longer required filesystem line * Update README to refelct only one tested arch Update to refelct CoreOS name change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the CoreOS example and replaces it with a working/tested one for Fedora CoreOS. I verified with and without qemu agent.