Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support TPM devices #890

Merged
merged 1 commit into from
Oct 11, 2021
Merged

Support TPM devices #890

merged 1 commit into from
Oct 11, 2021

Conversation

klausenbusk
Copy link
Contributor

@klausenbusk klausenbusk commented Oct 5, 2021

"TPM (Trusted Platform Module) is a computer chip (microcontroller) that
can securely store artifacts used to authenticate the platform (your PC
or laptop). These artifacts can include passwords, certificates, or
encryption keys. A TPM can also be used to store platform measurements
that help ensure that the platform remains trustworthy. Authentication
(ensuring that the platform can prove that it is what it claims to be)
and attestation (a process helping to prove that a platform is
trustworthy and has not been breached) are necessary steps to ensure
safer computing in all environments."[1]

A TPM device is required by Windows 11 and it is also useful for testing
TPM support and can be used for protecting secrets in guests.

[1] https://trustedcomputinggroup.org/resource/trusted-platform-module-tpm-summary/
[2] https://docs.microsoft.com/en-us/windows/whats-new/windows-11-requirements

Fix #888

"TPM (Trusted Platform Module) is a computer chip (microcontroller) that
can securely store artifacts used to authenticate the platform (your PC
or laptop). These artifacts can include passwords, certificates, or
encryption keys. A TPM can also be used to store platform measurements
that help ensure that the platform remains trustworthy. Authentication
(ensuring that the platform can prove that it is what it claims to be)
and attestation (a process helping to prove that a platform is
trustworthy and has not been breached) are necessary steps to ensure
safer computing in all environments."[1]

A TPM device is required by Windows 11 and it is also useful for testing
TPM support and can be used for protecting secrets in guests.

[1] https://trustedcomputinggroup.org/resource/trusted-platform-module-tpm-summary/
[2] https://docs.microsoft.com/en-us/windows/whats-new/windows-11-requirements

Fix dmacvicar#888
@osherdp
Copy link

osherdp commented Oct 11, 2021

+1 for that amazing feature, and I'm definitely need it
@dmacvicar what will it take to make that in? :)

@dmacvicar
Copy link
Owner

Thanks for the contribution @klausenbusk.

If I hesitate to take code that add libvirt features in is mostly because:

  • I dislike that to avoid complexity on the Terraform schema, we flatten the original XML schema.
  • Acceptance tests

In this case, I consider the feature important enough to push the schema discussion for later, and that is a topic I expect to solve some day using code generation.

About tests, I see in this case it is not trivial (passthrough or emulator).

@dmacvicar dmacvicar merged commit f3edad3 into dmacvicar:main Oct 11, 2021
@klausenbusk klausenbusk deleted the tpm branch October 13, 2021 06:54
@osherdp
Copy link

osherdp commented Oct 25, 2021

@dmacvicar is there any due date for the next release?

@osherdp
Copy link

osherdp commented Oct 25, 2021

@ybettan

@dmacvicar
Copy link
Owner

In the next weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support TPM devices
3 participants