Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement network detection for static IPs #766

Merged
merged 1 commit into from
Aug 10, 2020

Conversation

johscheuer
Copy link
Contributor

An idea how to fix #759 to enable the network detection (we still need to solve the xml generation for the host/dhcp entry).

I moved TestAccLibvirtDomain_Consoles into a separate file with linux only otherwise I was not able to run the tests locally, since syscall.TIOCGPTN is not supported on MacOS.

@MalloZup MalloZup self-requested a review August 6, 2020 16:40
Copy link
Collaborator

@MalloZup MalloZup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good . great work

@MalloZup
Copy link
Collaborator

MalloZup commented Aug 6, 2020

@johscheuer can you check travis? should be a minor lint

go run golang.org/x/lint/golint -set_exit_status ./libvirt .

libvirt/resource_libvirt_domain_test_linux.go:33:1: exported function TestAccLibvirtDomain_Consoles should have comment or be unexported

libvirt/resource_libvirt_domain_test_linux.go:33:6: don't use underscores in Go names; func TestAccLibvirtDomain_Consoles should be TestAccLibvirtDomainConsoles

Found 2 lint suggestions; failing.

exit status 1

Makefile:42: recipe for target 'lint-check' failed

make: *** [lint-check] Error 1

The command "make lint-check" exited with 2.```

@johscheuer
Copy link
Contributor Author

The lint issue should be fixed now. The funny thing is that when I run make lint-check golint doesn't complain 🤔

@MalloZup MalloZup merged commit 857ee50 into dmacvicar:master Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to create dual stack network with static IP's
2 participants