Add Combustion resource to use instead of the ignition one #1068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbosdo
added a commit
to cbosdo/sumaform
that referenced
this pull request
Feb 12, 2024
In order to support leap micro we need combustion support in the libvirt provider. This requires this pull request: dmacvicar/terraform-provider-libvirt#1068
cbosdo
added a commit
to cbosdo/sumaform
that referenced
this pull request
Feb 13, 2024
In order to support leap micro we need combustion support in the libvirt provider. This requires this pull request: dmacvicar/terraform-provider-libvirt#1068
cbosdo
added a commit
to cbosdo/sumaform
that referenced
this pull request
Feb 13, 2024
In order to support leap micro we need combustion support in the libvirt provider. This requires this pull request: dmacvicar/terraform-provider-libvirt#1068
jordimassaguerpla
pushed a commit
to jordimassaguerpla/sumaform
that referenced
this pull request
Mar 6, 2024
In order to support leap micro we need combustion support in the libvirt provider. This requires this pull request: dmacvicar/terraform-provider-libvirt#1068
jordimassaguerpla
pushed a commit
to jordimassaguerpla/sumaform
that referenced
this pull request
Mar 8, 2024
In order to support leap micro we need combustion support in the libvirt provider. This requires this pull request: dmacvicar/terraform-provider-libvirt#1068
cbosdo
added a commit
to cbosdo/sumaform
that referenced
this pull request
Mar 8, 2024
In order to support leap micro we need combustion support in the libvirt provider. This requires this pull request: dmacvicar/terraform-provider-libvirt#1068
cbosdo
added a commit
to uyuni-project/sumaform
that referenced
this pull request
Mar 8, 2024
In order to support leap micro we need combustion support in the libvirt provider. This requires this pull request: dmacvicar/terraform-provider-libvirt#1068
|
I am ok with the hack, but I think a comment above the flag should make explicit what we are doing. |
jordimassaguerpla
pushed a commit
to jordimassaguerpla/sumaform
that referenced
this pull request
Mar 27, 2024
In order to support leap micro we need combustion support in the libvirt provider. This requires this pull request: dmacvicar/terraform-provider-libvirt#1068 Review configuration for PR testing Signed-off-by: Jordi Massaguer Pla <jmassaguerpla@suse.com>
jordimassaguerpla
pushed a commit
to jordimassaguerpla/sumaform
that referenced
this pull request
Mar 27, 2024
In order to support leap micro we need combustion support in the libvirt provider. This requires this pull request: dmacvicar/terraform-provider-libvirt#1068 Review configuration for PR testing Signed-off-by: Jordi Massaguer Pla <jmassaguerpla@suse.com>
jordimassaguerpla
pushed a commit
to jordimassaguerpla/sumaform
that referenced
this pull request
Mar 27, 2024
In order to support leap micro we need combustion support in the libvirt provider. This requires this pull request: dmacvicar/terraform-provider-libvirt#1068 Review configuration for PR testing Signed-off-by: Jordi Massaguer Pla <jmassaguerpla@suse.com>
Sorry for the late reply. I added a comment on the Combustion member of the definition. I hope that's what you meant. |
|
Integration tests are broken after I merged:
|
Just saw the message after vacation and filed a PR to fix it. |
dmacvicar
pushed a commit
to jimnydev/terraform-provider-libvirt
that referenced
this pull request
Sep 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since combustion is very similar to ignition, add another resource based on the ignition one, just adding a flag to disable the JSON unmarshalling error.