Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix copy of the URL in RemoteName #1044

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Fix copy of the URL in RemoteName #1044

merged 1 commit into from
Nov 3, 2023

Commits on Nov 3, 2023

  1. Fix copy of the URL in RemoteName 

    Fixes dmacvicar#1040

The copy performed in RemoteName was shallow and this corrupted the
original URI that is used during the Dial() call made by the go-libvirt
library.

The issue always existed but did not manifest when libvirt.New(conn) was
used because the connection was established before the call to
RemoteName. The problem manifested when the switch to
libvirt.NewWithDialer was made, because the dialing is now made during
the call to ConnectToURI, which receives as paramater the result of the
call to RemoteName.
    Florian Maury committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    9fbef0b View commit details
    Browse the repository at this point in the history