Replace node-sass with sass #786

MrFlashAccount · 2021-02-05T13:31:54Z

Node-sass is deprecated, I've moved this project to sass.

ruxxzebre · 2021-02-11T12:58:52Z

I had a lot of troubles with that, because of incompatibility of node-sass 4 with osx manjaro (!!!!),
so it would be great for the maintainer to fix this, or at least update node-sass to 5.

ruxxzebre · 2021-02-11T13:04:10Z

@MrFlashAccount friendly suggestion, config your global gitignore to ignore the .idea, .vscode, etc, so not to mess the project's gitignore file, because it's not the best practice, kinda clogging project a bit.
Also, it'll just make your life easier, so you don't need to mention temp files and other cache folders in every project.
Peace :3

MrFlashAccount · 2021-02-12T11:56:19Z

@ruxxzebre thank you for your advice :)

jerrylow · 2021-02-23T21:12:01Z

BTW tested this PR and it's working great.

Prometee · 2021-04-30T22:40:14Z

.gitignore

@@ -13,3 +13,4 @@ results

 npm-debug.log
 node_modules
+.idea


This shouldn't be here, you have to manage a global ignore file into your own environment.
You can find many articles about this fact on internet like this one :
https://blog.martinhujer.cz/dont-put-idea-vscode-directories-to-projects-gitignore/

Prometee · 2021-04-30T22:44:38Z

yarn.lock

+  integrity sha1-RQ1Nyfpw3nMnYvvS1KKJgUGaDM8=
+
+v8flags@^2.0.2:
+  version "2.1.1"
+  resolved "https://registry.yarnpkg.com/v8flags/-/v8flags-2.1.1.tgz#aab1a1fa30d45f88dd321148875ac02c0b55e5b4"
+  integrity sha1-qrGh+jDUX4jdMhFIh1rALAtV5bQ=
+  dependencies:
+    user-home "^1.1.1"
+
+validate-npm-package-license@^3.0.1:
+  version "3.0.4"
+  resolved "https://registry.yarnpkg.com/validate-npm-package-license/-/validate-npm-package-license-3.0.4.tgz#fc91f6b9c7ba15c857f4cb2c5defeec39d4f410a"
+  integrity sha512-DpKm2Ui/xN7/HQKCtpZxoRWBhZ9Z0kqtygG8XCgNQ8ZlDnxuQmWhj566j8fN4Cu3/JmbhsDo7fcAJq4s9h27Ew==
+  dependencies:
+    spdx-correct "^3.0.0"
+    spdx-expression-parse "^3.0.0"
+
+vinyl-fs@^0.3.0:
+  version "0.3.14"
+  resolved "https://registry.yarnpkg.com/vinyl-fs/-/vinyl-fs-0.3.14.tgz#9a6851ce1cac1c1cea5fe86c0931d620c2cfa9e6"
+  integrity sha1-mmhRzhysHBzqX+hsCTHWIMLPqeY=
+  dependencies:
+    defaults "^1.0.0"
+    glob-stream "^3.1.5"
+    glob-watcher "^0.0.6"
+    graceful-fs "^3.0.0"
+    mkdirp "^0.5.0"
+    strip-bom "^1.0.0"
+    through2 "^0.6.1"
+    vinyl "^0.4.0"
+
+vinyl-sourcemaps-apply@^0.2.0, vinyl-sourcemaps-apply@^0.2.1:
+  version "0.2.1"
+  resolved "https://registry.yarnpkg.com/vinyl-sourcemaps-apply/-/vinyl-sourcemaps-apply-0.2.1.tgz#ab6549d61d172c2b1b87be5c508d239c8ef87705"
+  integrity sha1-q2VJ1h0XLCsbh75cUI0jnI74dwU=
+  dependencies:
+    source-map "^0.5.1"
+
+vinyl@^0.4.0:
+  version "0.4.6"
+  resolved "https://registry.yarnpkg.com/vinyl/-/vinyl-0.4.6.tgz#2f356c87a550a255461f36bbeb2a5ba8bf784847"
+  integrity sha1-LzVsh6VQolVGHza76ypbqL94SEc=
+  dependencies:
+    clone "^0.2.0"
+    clone-stats "^0.0.1"
+
+vinyl@^0.5.0:
+  version "0.5.3"
+  resolved "https://registry.yarnpkg.com/vinyl/-/vinyl-0.5.3.tgz#b0455b38fc5e0cf30d4325132e461970c2091cde"
+  integrity sha1-sEVbOPxeDPMNQyUTLkYZcMIJHN4=
+  dependencies:
+    clone "^1.0.0"
+    clone-stats "^0.0.1"
+    replace-ext "0.0.1"
+
+vinyl@^2.1.0:
+  version "2.2.1"
+  resolved "https://registry.yarnpkg.com/vinyl/-/vinyl-2.2.1.tgz#23cfb8bbab5ece3803aa2c0a1eb28af7cbba1974"
+  integrity sha512-LII3bXRFBZLlezoG5FfZVcXflZgWP/4dCwKtxd5ky9+LOtM4CS3bIRQsmR1KMnMW07jpE8fqR2lcxPZ+8sJIcw==
+  dependencies:
+    clone "^2.1.1"
+    clone-buffer "^1.0.0"
+    clone-stats "^1.0.0"
+    cloneable-readable "^1.0.0"
+    remove-trailing-separator "^1.0.1"
+    replace-ext "^1.0.0"
+
+which@^1.2.14, which@^1.2.9:
+  version "1.3.1"
+  resolved "https://registry.yarnpkg.com/which/-/which-1.3.1.tgz#a45043d54f5805316da8d62f9f50918d3da70b0a"
+  integrity sha512-HxJdYWq1MTIQbJ3nw0cqssHoTNU267KlrDuGZ1WYlxDStUtKUhOaJmh112/TZmHxxUfuJqPXSOm7tDyas0OSIQ==
+  dependencies:
+    isexe "^2.0.0"
+
+word-wrap@~1.2.3:
+  version "1.2.3"
+  resolved "https://registry.yarnpkg.com/word-wrap/-/word-wrap-1.2.3.tgz#610636f6b1f703891bd34771ccb17fb93b47079c"
+  integrity sha512-Hz/mrNwitNRh/HUAtM/VT/5VH+ygD6DV7mYKZAtHOrbs8U7lvPS6xf7EJKMF0uW1KJCl0H701g3ZGus+muE5vQ==
+
+wrappy@1:
+  version "1.0.2"
+  resolved "https://registry.yarnpkg.com/wrappy/-/wrappy-1.0.2.tgz#b5243d8f3ec1aa35f1364605bc0d1036e30ab69f"
+  integrity sha1-tSQ9jz7BqjXxNkYFvA0QNuMKtp8=
+
+write@^0.2.1:
+  version "0.2.1"
+  resolved "https://registry.yarnpkg.com/write/-/write-0.2.1.tgz#5fc03828e264cea3fe91455476f7a3c566cb0757"
+  integrity sha1-X8A4KOJkzqP+kUVUdvejxWbLB1c=
+  dependencies:
+    mkdirp "^0.5.1"
+
+"xtend@>=4.0.0 <4.1.0-0", xtend@~4.0.1:
+  version "4.0.2"
+  resolved "https://registry.yarnpkg.com/xtend/-/xtend-4.0.2.tgz#bb72779f5fa465186b1f438f674fa347fdb5db54"
+  integrity sha512-LKYU1iAXJXUgAXn9URjiu+MWhyUXHsvfp7mcuYm9dSUKK0/CjtrUwFAxD82/mCWbtLsGjFIad0wIsod4zrTAEQ==
+
+yallist@^2.1.2:
+  version "2.1.2"
+  resolved "https://registry.yarnpkg.com/yallist/-/yallist-2.1.2.tgz#1c11f9218f076089a47dd512f93c6699a6a81d52"
+  integrity sha1-HBH5IY8HYImkfdUS+TxmmaaoHVI=


This file shouldn't be committed too, only your own private project repository must hold it.

No, I disagree with you. Yarn.lock should always be committed: https://classic.yarnpkg.com/en/docs/yarn-lock/#toc-check-into-source-control

For your own projects it's very important, for libraries like this repository it's completely useless because it won't be used by the owning project.

There isn’t really any hard rules around this just strong opinions.

It’s not completely useless because it could be useful for contributors to the library.

It's useful when you need to get a specific version to keep a production app working. In this case (library project) it's useful to get ride of it, because libraries need to know if they are working with the latest version of the dependencies available when they are tested through GitHub actions for example.

I understand and agree with you from library's users perspective, but:

this file won't be published, so users shouldn't worry about this file

this file specify not only dependencies, but also a dev deps and this is very important since we have to build and test our library in github actions.

manelephant · 2021-05-10T09:33:55Z

Would be great if this could be merged

tachojelev · 2021-05-21T14:42:08Z

Hi guys, when can we expect this to be merged and released?

darkoandreev · 2021-05-21T14:43:02Z

Hi guys, our project highly depends on this PR. It would be really nice if @Prometee and @jerrylow could review it. Thanks in advance!

yairEO · 2021-06-06T09:47:05Z

I also need this urgently... may the author perhaps do these quick 2-lines changes himself directly on the Master branch and rid us of the huge waste of time - arguing about all those extra files added to this PR? 🧐🥱

Prometee · 2021-06-06T11:17:08Z

@yairEO I'm not the library author just a random dev having the same problem like you. Reviews on this repository are open to all GitHub accounts, only the maintainers are able to accept or refuse this PR.

yairEO · 2021-06-06T15:15:59Z

Yes, I know, I was writing this for the maintainer to read

richard-giraud · 2021-06-10T20:27:37Z

I've submitted a PR that is the same, except it doesn't have the idea folder or the yarn.lock files.

xzyfer · 2021-06-15T07:10:34Z

Thanks all, close this to focus efforts on #802 which is more rounded at this point in time.

Replace node-sass with sass

a3f9448

jerrylow mentioned this pull request Feb 23, 2021

Depends on node-sass #785

Closed

patrickkettner mentioned this pull request Apr 1, 2021

node-sass deprecated, should be replaced ampproject/amp.dev#5632

Closed

MasatoMakino mentioned this pull request Apr 27, 2021

gulp-sassがnode-sass v4に依存している MasatoMakino/gulptask-sass#4

Closed

Prometee reviewed Apr 30, 2021

View reviewed changes

yairEO mentioned this pull request Jun 6, 2021

Replace division operators in tagify.scss with math.div yairEO/tagify#831

Closed

richard-giraud mentioned this pull request Jun 10, 2021

Replace node-sass with sass #800

Closed

xzyfer closed this Jun 15, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace node-sass with sass #786

Replace node-sass with sass #786

MrFlashAccount commented Feb 5, 2021

ruxxzebre commented Feb 11, 2021

ruxxzebre commented Feb 11, 2021

MrFlashAccount commented Feb 12, 2021

jerrylow commented Feb 23, 2021

Prometee Apr 30, 2021

Prometee Apr 30, 2021

MrFlashAccount May 1, 2021

Prometee May 1, 2021

jerrylow May 1, 2021

Prometee May 1, 2021

MrFlashAccount May 2, 2021

manelephant commented May 10, 2021 •

edited

Loading

tachojelev commented May 21, 2021

darkoandreev commented May 21, 2021

yairEO commented Jun 6, 2021 •

edited

Loading

Prometee commented Jun 6, 2021

yairEO commented Jun 6, 2021

richard-giraud commented Jun 10, 2021

xzyfer commented Jun 15, 2021

Replace node-sass with sass #786

Replace node-sass with sass #786

Conversation

MrFlashAccount commented Feb 5, 2021

ruxxzebre commented Feb 11, 2021

ruxxzebre commented Feb 11, 2021

MrFlashAccount commented Feb 12, 2021

jerrylow commented Feb 23, 2021

Prometee Apr 30, 2021

Choose a reason for hiding this comment

Prometee Apr 30, 2021

Choose a reason for hiding this comment

MrFlashAccount May 1, 2021

Choose a reason for hiding this comment

Prometee May 1, 2021

Choose a reason for hiding this comment

jerrylow May 1, 2021

Choose a reason for hiding this comment

Prometee May 1, 2021

Choose a reason for hiding this comment

MrFlashAccount May 2, 2021

Choose a reason for hiding this comment

manelephant commented May 10, 2021 • edited Loading

tachojelev commented May 21, 2021

darkoandreev commented May 21, 2021

yairEO commented Jun 6, 2021 • edited Loading

Prometee commented Jun 6, 2021

yairEO commented Jun 6, 2021

richard-giraud commented Jun 10, 2021

xzyfer commented Jun 15, 2021

manelephant commented May 10, 2021 •

edited

Loading

yairEO commented Jun 6, 2021 •

edited

Loading