Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add relativePath property to error object for notification(s) support #417

Merged
merged 2 commits into from
Dec 21, 2015

Conversation

ajschlosser
Copy link
Contributor

This would particularly be useful for use with gulp-notify.

I've also added a corresponding assertions to the respective "should handle sass errors" tests.

@ajschlosser
Copy link
Contributor Author

Just noticed that this addresses part of #399. If @jlgeering has his own PR ready for this, feel free to close this one--don't want to step on anybody's toes!

@jlgeering
Copy link
Contributor

Hi @ajschlosser, I just closed my issue, as you already submitted a PR.

Cloud you add the originalMessage property too (also useful for notifications)

      error.originalMessage = error.message
      error.message = gutil.colors.stripColor(message);

or maybe

      error.messageFormatted = gutil.colors.stripColor(message);

=> the goal is to have access to error.message from node-sass

And now that I read my comment ... It could be a separate Issue / PR ;-)

@jlgeering
Copy link
Contributor

forget my last comment, created a separate PR for it: #420

Keats added a commit that referenced this pull request Dec 21, 2015
add relativePath property to error object for notification(s) support
@Keats Keats merged commit 847a2d3 into dlmanning:master Dec 21, 2015
@ajschlosser
Copy link
Contributor Author

@jlgeering Thanks for the update! Good call on preserving the original message, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants