Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android Gradle plugin 1.3.0 does not allow _ as an initial letter in resources #47

Merged
merged 2 commits into from
Jun 1, 2015
Merged

Android Gradle plugin 1.3.0 does not allow _ as an initial letter in resources #47

merged 2 commits into from
Jun 1, 2015

Conversation

gfx
Copy link
Contributor

@gfx gfx commented May 29, 2015

Fixed #46. See https://github.com/gfx/joda-time-android/commit/bc66e734b63344043a71dbe2b800084559162078 for changes. https://github.com/gfx/joda-time-android/commit/a3b7c72c3a6979813dbd6eaa38b715d16294ff5a is just an update for tz data.

By the way, ./gradlew connectedCheck does not pass on my env even if on the master branch :(

@dlew
Copy link
Owner

dlew commented May 29, 2015

./gradlew connectedCheck probably fails because of date/timezone settings on the device. I should specify better what's needed in order for the test to run properly. (I haven't gone so far as to manipulate the device settings to run the test.)

I'm fairly busy with IO today but at a glance this looks good.

dlew added a commit that referenced this pull request Jun 1, 2015
Android Gradle plugin 1.3.0 does not allow _ as an initial letter in resources
@dlew dlew merged commit 4a37a20 into dlew:master Jun 1, 2015
@dlew
Copy link
Owner

dlew commented Jun 1, 2015

Sorry for the delay, I got the conference crud! This looks good to me.

@gfx
Copy link
Contributor Author

gfx commented Jun 1, 2015

Thanks. No problem ;)

@gfx gfx deleted the gradle_plugin_130 branch June 1, 2015 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mergeResources error with Android Gradle plugin 1.3
2 participants