Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 24801 - RefRange doesn’t work if range primitives are not const #9056

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Ogi-kun
Copy link
Contributor

@Ogi-kun Ogi-kun commented Oct 9, 2024

No description provided.

@dlang-bot
Copy link
Contributor

dlang-bot commented Oct 9, 2024

Thanks for your pull request and interest in making D better, @Ogi-kun! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
24801 normal `RefRange` doesn’t work if range primitives are not `const`

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#9056"

@thewilsonator
Copy link
Contributor

Please retitle the commit message "Fix Bugzilla issue 24801 - RefRange doesn’t work if range primitives are not const"

@Ogi-kun
Copy link
Contributor Author

Ogi-kun commented Oct 13, 2024

Any problems with this PR, besides macOS tests being broken right now?

@pbackus pbackus added the 72h no objection -> merge The PR will be merged if there are no objections raised. label Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
72h no objection -> merge The PR will be merged if there are no objections raised. Bug Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants