-
-
Notifications
You must be signed in to change notification settings - Fork 700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove -de switch from Phobos builds to allow deprecations. #9052
Conversation
Thanks for your pull request and interest in making D better, @LightBender! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + phobos#9052" |
Why is this necessary ? My understanding is that we want Phobos to build without deprecation in itself, but that doesn't prevent it from exposing deprecated symbols ? |
Two reasons:
|
Agree-ish, but that really should be its own discussion point.
We can absolutely do that. I fail to recall a time when it was not possible. |
Sure, but I would strongly argue that it's bad practice to use
Well, the last time I tried to deprecate something in Phobos (which was ultimately shot down in that specific case), putting |
Remove the -de switch to allow future deprecations in Phobos.