Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 24095 - std.bitmanip.bitfields no longer works with bool enum t… #9043

Merged
merged 3 commits into from
Aug 19, 2024

Conversation

RubyTheRoobster
Copy link
Contributor

No description provided.

@dlang-bot
Copy link
Contributor

dlang-bot commented Aug 6, 2024

Thanks for your pull request and interest in making D better, @RubyTheRoobster! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
24095 regression std.bitmanip.bitfields no longer works with bool enum types

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + phobos#9043"

Copy link
Contributor

@thewilsonator thewilsonator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please retitle the commit message "Fix bugzilla 24095: ..."

@thewilsonator
Copy link
Contributor

Check for trailing whitespace
grep -nr '[[:blank:]]$' $(find etc std -name '*.d'); test $? -eq 1
std/bitmanip.d:4748:

@RazvanN7 RazvanN7 merged commit cd02612 into dlang:stable Aug 19, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants