Let Dependency use generic interval logic. #1284
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request, @s-ludwig! |
s-ludwig
force-pushed
the
version-interval
branch
from
e83d886 to
428c819
Compare
s-ludwig
force-pushed
the
version-interval
branch
from
18a78c2 to
7b13291
Compare
|
Just noticed that there is still a "BUG" comment in the rebased code. |
|
Done in #2271 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Dependencyto rely on generic interval operations instead of manually working with version bounds all over the place. This makes it considerably easier to reason about such operations and simplifies the logic withinDependency.