add -conf=path compiler switch #4256

MartinNowak · 2015-01-06T02:37:15Z

No description provided.

MartinNowak · 2015-01-06T02:39:55Z

See the references above for how people struggle with the current behavior.

braddr · 2015-01-06T04:12:50Z

A reasonable case can be made for just about any ordering. I don't think this change is categorically better than the current one. An argument could probably be made for ordering along with a policy/procedure for merging, but even that's fraught with fun.

Or, hrm.. never tried it, but can you do something like DFLAGS=$DFLAGS -Inewdir in dmd.conf right now?

For the sake of testing and guaranteed consistency of them, a command line parameter to point to the config file to use would probably be best. Assuming it also overrides any other search and internal defaults.

WalterBright · 2015-01-06T05:47:12Z

People tend to "fire and forget" their dmd.conf. Changing the search order will unexpectedly break things for them. It's like changing the way make works - what a disaster that is for people who cut&paste their makefiles with no understanding.

yebblies · 2015-01-06T05:51:17Z

This order makes more sense, because you want to configure different
compilers so the configuration should be attached to the compiler not
your current working dir.

On the other hand, sometimes you want to override sc.ini for a local project. I'm not sure what the best way is, but it's really annoying not being able to use a specific config file.

MartinNowak · 2015-01-06T13:57:26Z

A reasonable case can be made for just about any ordering.

No it can't, it's an installation time configuration for the compiler. That doesn't change when you cd into another directory. The current search order is nonsense because it favors using the same configuration for multiple compilers over using specific configurations per compiler.

On the other hand, sometimes you want to override sc.ini for a local project.

That's what you'd use a compiler switch for that specifies an alternative configuration.
Picking up the conf of the current directory means it will be used by any different compiler which leads to the know trouble.

People tend to "fire and forget" their dmd.conf. Changing the search order will unexpectedly break things for them.

Yeah, I'm also worried about that. Now I wonder who uses the current search order to override it's configuration. We could detect that and ask the people to move the config files.
And we should still add a switch to the compiler to select a specific config.

yebblies · 2015-01-06T14:22:34Z

That's what you'd use a compiler switch for that specifies an alternative configuration.

Sure, if we had one.

And we should still add a switch to the compiler to select a specific config.

Yes please.

ghost · 2015-01-06T18:18:07Z

And we should still add a switch to the compiler to select a specific config.

That would probably be the best solution.

MartinNowak · 2015-01-06T18:26:27Z

I'm search for both the new and the old order. If there is a mismatch an informational warning is printed, advising people to use the newly added -conf=path switch to select a non-standard configuration.

Once again the old order is culprit for many dmd.conf related issues, because it doesn't make sense that my installed compiler picks up a different config file depending on where I am.
Note that it's still possible to override the config of the system wide dmd by adding a dmd.conf in your HOME folder.
The current working directory will only be used as last resort, because you do not want to configure all compilers on a per project base.

WalterBright · 2015-01-06T19:39:37Z

because it doesn't make sense that my installed compiler picks up a different config file depending on where I am.

It seems obvious to me that when I am in my project directory, that it picks up the config file from that directory. I use it all the time.

Anyhow, a compiler flag sounds fine, but not a redo of the order and the attendant confusion and breakage that will cause.

If there is a mismatch an informational warning is printed

That just seems like layers of more complexity.

andralex · 2015-01-06T20:27:36Z

I disagree with the proposed order; local stuff should override global stuff. So things are good as they are. To override the global stuff just create a local conf file.

I'm okay with adding a flag though I see all this unnecessary churn and the illusion of progress because a simple and effective solution is available.

MartinNowak · 2015-01-06T20:33:21Z

I disagree with the proposed order; local stuff should override global stuff.

Yes, local to the compiler you're using.
Anyhow can't seem to convince anyone, so I'll just add the flag.

- allows to specify a compiler config file

MartinNowak · 2015-01-06T20:52:29Z

Now it's only the -conf=path switch. I also left in the additions to error.c.

It seems obvious to me that when I am in my project directory, that it picks up the config file from that directory. I use it all the time.

It's obvious for things that you want to configure on a per-project base, like say which compiler version to use. But it doesn't make sense to use the same compiler configuration for every compiler.
And because @P is relative to the dmd.conf path, you'd have to hardcode phobos and druntime. How is that useful? It makes it impossible to compile the project with different dmd compilers.
And what is it that you're actually configuring? DFLAGS?

You're configuring the compiler not your project, therefor you need to lookup the config file from where the compiler is installed not from where your project lives.

andralex · 2015-01-07T02:49:48Z

src/mars.c

+        {
+            if (strncmp(p + 1, "conf=", 5) == 0)
+                conf = p + 6;
+            else if (strcmp(p + 1, "run") == 0)


what's "run" doing here?

In dmd -run myprog.d -conf=dmd.conf the -conf=dmd.conf argument belongs to myprog.

andralex · 2015-01-07T03:01:38Z

If -conf= is passed without an argument, will that make dmd to use no conf file at all?

yebblies · 2015-01-07T03:40:17Z

src/errors.c

- * Used for backtraces, etc
- */
-void errorSupplemental(Loc loc, const char *format, ...)
+void warningSupplemental(Loc loc, const char *format, ...)


Don't add these if they're not used.

I already needed them earlier and it just makes the API consistent.

MartinNowak · 2015-01-07T17:56:43Z

If -conf= is passed without an argument, will that make dmd to use no conf file at all?

Good idea, added that.

andralex · 2015-01-07T22:42:08Z

src/inifile.c

@@ -296,7 +299,7 @@ const char *inifile(const char *argv0, const char *inifile, const char *envsecti
                break;
        }
    }
-    return filename;
+    return;


unnecessary return at end of function

andralex · 2015-01-07T22:42:45Z

Auto-merge toggled on

add -conf=path compiler switch

MartinNowak · 2015-04-01T02:20:02Z

tl;dr, please reconsider changing the conf order or splitting the conf file

That dmd.conf is driving me crazy.

I need a dmd.conf in my dmd repo, so that I can use dmd-master. It wouldn't work without a config and putting dmd.conf anywhere but near dmd itself overrides my system dmd.conf.
That setup worked nicely for me although some of you guys seem to have a dmd.conf in your home dir (why?).

Now that we require a host D compiler to build dmd it no longer works, because the dmd.conf for my dmd-master overrides the system wide dmd.conf of my host dmd.
Why would my system dmd need a different configuration just because I am in a different folder?
It doesn't, it still uses the same phobos (the system wide) and still requires the same linker switches.

Setting HOST_DC is a workaround but is impractical, because it requires an awkward env HOST_DC='dmd -conf=/etc/dmd.conf' make -f posix.mak to work.
Requiring dmd -conf=/etc/dmd.conf in order to not pickup some random conf file is crazy. It's not portable either, because the config is somewhere else on each platform.

We learned the same from dlang.org dlang/dlang.org#758 (comment), adding the -conf= switch didn't solve the actual problem and created new ones.

It might seem intuitive, that a local configuration should override a global one, but it's a false friend here, because the configuration should be local from the perspective of the compiler, not from the perspective of the user.

In fact the config is so tied to the compiler that we could almost compile it into the compiler (like gcc does with it's spec). At best it's something package maintainers need to touch to accomodate platform differences, but it's not a user configuration file.

If people use it to configure DFLAGS and such project dependent stuff, then we need to split the configuration file, into one part that tells the compiler where to find druntime/phobos and how to link, and one part that can be used for per-project configuration of compiler arguments and env variables.
IMO the latter is better kept in makefiles/dub.json though.

conclusion

The lookup order for the config file should be changed to the following.

next to dmd binary (highest precedence so that I can have multiple installations)
per-user conf folder (HOME) (to override the system-wide config)
system-wide conf folder (to allow package installations .deb/.rpm)

The current situation is unmaintainable.

This was referenced Jan 6, 2015

Config file in dmd dir prevents host dmd from working braddr/d-tester#40

Closed

build a stable dub version for dpl-docs dlang/dlang.org#742

Merged

MartinNowak force-pushed the dmdConfSearchOrder branch from 177a003 to baddfcf Compare January 6, 2015 02:38

MartinNowak added 2 commits January 6, 2015 18:42

add warningSupplemental and deprecationSupplemental

d8ebbc4

fix comment

aba8f66

MartinNowak force-pushed the dmdConfSearchOrder branch from baddfcf to 0d77bfc Compare January 6, 2015 17:58

MartinNowak force-pushed the dmdConfSearchOrder branch from 0d77bfc to f5e8b48 Compare January 6, 2015 18:18

MartinNowak force-pushed the dmdConfSearchOrder branch from f5e8b48 to b131af1 Compare January 6, 2015 18:27

add a -conf=path swith

6a941e3

- allows to specify a compiler config file

MartinNowak force-pushed the dmdConfSearchOrder branch from b131af1 to 6a941e3 Compare January 6, 2015 20:45

MartinNowak changed the title ~~change search order for inifile~~ add -conf=path compiler switch Jan 6, 2015

andralex reviewed Jan 7, 2015
View reviewed changes

yebblies reviewed Jan 7, 2015
View reviewed changes

MartinNowak force-pushed the dmdConfSearchOrder branch from ec1fd40 to b6515ed Compare January 7, 2015 17:57

an empty path means no conf should be used

b6515ed

andralex reviewed Jan 7, 2015
View reviewed changes

andralex added a commit that referenced this pull request Jan 7, 2015

Merge pull request #4256 from MartinNowak/dmdConfSearchOrder

3a0637a

add -conf=path compiler switch

andralex merged commit 3a0637a into dlang:master Jan 7, 2015

MartinNowak deleted the dmdConfSearchOrder branch January 17, 2015 14:07

MartinNowak mentioned this pull request Jan 17, 2015

Add -conf= to dmd invocations dlang/dlang.org#758

Merged

MartinNowak mentioned this pull request Feb 18, 2018

Add '--dmd' and '--dc' to print the path of the installed compiler dlang/installer#297

Merged

wilzbach mentioned this pull request Feb 19, 2018

Improve the lookup sequence for finding the config file #7915

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add -conf=path compiler switch #4256

add -conf=path compiler switch #4256

MartinNowak commented Jan 6, 2015

MartinNowak commented Jan 6, 2015

braddr commented Jan 6, 2015

WalterBright commented Jan 6, 2015

yebblies commented Jan 6, 2015

MartinNowak commented Jan 6, 2015

yebblies commented Jan 6, 2015

ghost commented Jan 6, 2015

MartinNowak commented Jan 6, 2015

WalterBright commented Jan 6, 2015

andralex commented Jan 6, 2015

MartinNowak commented Jan 6, 2015

MartinNowak commented Jan 6, 2015

andralex Jan 7, 2015

MartinNowak Jan 7, 2015

andralex commented Jan 7, 2015

yebblies Jan 7, 2015

MartinNowak Jan 7, 2015

MartinNowak commented Jan 7, 2015

andralex Jan 7, 2015

andralex commented Jan 7, 2015

MartinNowak commented Apr 1, 2015

add -conf=path compiler switch #4256

add -conf=path compiler switch #4256

Conversation

MartinNowak commented Jan 6, 2015

MartinNowak commented Jan 6, 2015

braddr commented Jan 6, 2015

WalterBright commented Jan 6, 2015

yebblies commented Jan 6, 2015

MartinNowak commented Jan 6, 2015

yebblies commented Jan 6, 2015

ghost commented Jan 6, 2015

MartinNowak commented Jan 6, 2015

WalterBright commented Jan 6, 2015

andralex commented Jan 6, 2015

MartinNowak commented Jan 6, 2015

MartinNowak commented Jan 6, 2015

andralex Jan 7, 2015

Choose a reason for hiding this comment

MartinNowak Jan 7, 2015

Choose a reason for hiding this comment

andralex commented Jan 7, 2015

yebblies Jan 7, 2015

Choose a reason for hiding this comment

MartinNowak Jan 7, 2015

Choose a reason for hiding this comment

MartinNowak commented Jan 7, 2015

andralex Jan 7, 2015

Choose a reason for hiding this comment

andralex commented Jan 7, 2015

MartinNowak commented Apr 1, 2015

conclusion