Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dub recipe for the lexer subpackage #17031

Merged
merged 1 commit into from
Oct 26, 2024

Conversation

Vladiwostok
Copy link
Contributor

Some of the errors.d code has been moved in sarif.d.

When using dmd in a dub project, dub fails to build the lexer subpackage due to the missing dependency.

This PR fixes the issue by specifying the sarif.d dependency in the lexer subpackage

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @Vladiwostok! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#17031"

@thewilsonator
Copy link
Contributor

Thanks!

@dlang-bot dlang-bot merged commit 4a90885 into dlang:master Oct 26, 2024
40 of 41 checks passed
@Vladiwostok Vladiwostok deleted the fix-dub-sarif branch October 26, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants