Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dsymbolsem/InstMemberWalker: also visit generated structs' members #17022

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

yanok
Copy link
Contributor

@yanok yanok commented Oct 23, 2024

While updating children's minst only going over members is not enough: structs may also have generated methods that are not in members.

As a result, if a generated method instantiates a template, it gets a poentially wrong minst, so can be omitted from the compilation result.

Fixes Bugzilla Issue 24830

@dlang-bot
Copy link
Contributor

dlang-bot commented Oct 23, 2024

Thanks for your pull request and interest in making D better, @yanok! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
24830 normal separate compilation + circular deps + templated opCmp = missing symbols

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#17022"

While updating children's `minst` only going over `members` is not
enough: structs may also have generated methods that are not in
`members`.

As a result, if a generated method instantiates a template, it gets a
poentially wrong `minst`, so can be omitted from the compilation result.

Fixes Bugzilla Issue 24830.
@dlang-bot dlang-bot merged commit ad91901 into dlang:master Oct 23, 2024
41 checks passed
@yanok yanok deleted the fix-issue24830 branch October 24, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants