Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable] GHA: Bump Xcode version to 15.1 for macOS-13 jobs #16240

Merged
merged 1 commit into from
Feb 24, 2024

Conversation

ibuclaw
Copy link
Member

@ibuclaw ibuclaw commented Feb 24, 2024

Nearly a dozen bug fixes later, all woes on macOS / Xcode 15 might now be dealt with.

As there is no release of dmd with these fixes in yet, use ldc as the host D compiler for the interim until a new release is made.

@dlang-bot
Copy link
Contributor

dlang-bot commented Feb 24, 2024

Thanks for your pull request, @ibuclaw!

Bugzilla references

Auto-close Bugzilla Severity Description
24407 critical OSX: ld: Assertion failed: (slot < _sideTableBuffer.size()), function addAtom

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + dmd#16240"

@ibuclaw ibuclaw requested a review from kinke February 24, 2024 00:32
@ibuclaw
Copy link
Member Author

ibuclaw commented Feb 24, 2024

Looks like CI found one more issue - https://issues.dlang.org/show_bug.cgi?id=24407

==============================
Test 'runnable/test17338.d' failed. The logged output:
/Users/runner/work/dmd/dmd/generated/osx/release/64/dmd -conf= -m64 -Irunnable  -fPIC  -od/Users/runner/work/dmd/dmd/compiler/test/test_results/runnable -of/Users/runner/work/dmd/dmd/compiler/test/test_results/runnable/test17338_0  runnable/test17338.d 
0  0x108b95f43  __assert_rtn + 64
1  0x108b61e75  ld::AtomFileConsolidator::addAtomFile(ld::AtomFile const*, ld::AtomFile const*, bool) + 8997
2  0x108b6fa78  ld::AtomFileConsolidator::addAtomFile(ld::AtomFile const*) + 136
3  0x108b94287  ld::pass::stubs(ld::Options const&, ld::AtomFileConsolidator&) + 2039
4  0x108b79184  ld::AtomFileConsolidator::resolve() + 18564
5  0x108ae4db8  main + 12344
ld: Assertion failed: (slot < _sideTableBuffer.size()), function addAtom, file AtomFileConsolidator.cpp, line 2158.
clang: error: linker command failed with exit code 1 (use -v to see invocation)
Error: linker exited with status 1
==============================

@ibuclaw
Copy link
Member Author

ibuclaw commented Feb 24, 2024

@ibuclaw
Copy link
Member Author

ibuclaw commented Feb 24, 2024

Checking Xcode 15.1...

@ibuclaw
Copy link
Member Author

ibuclaw commented Feb 24, 2024

Checking Xcode 15.1...

So, it turns out that Xcode 15.0.1 is a broken release for both DMD and GCC alike, and Apple have fixed it in Xcode 15.1.

That linker ICE is not worth the investigation, but we now have to switch to Xcode in the other direction to 15.1 instead while we wait for GHA to bump the default again.

@ibuclaw ibuclaw changed the title [stable] GHA: Remove Xcode workaround for macOS-13 jobs [stable] GHA: Bump Xcode version to 15.1 for macOS-13 jobs Feb 24, 2024
@ibuclaw
Copy link
Member Author

ibuclaw commented Feb 24, 2024

@thewilsonator build is green, just updated commit and this PR title to reflect new change.

https://github.com/dlang/dmd/actions/runs/8027176846/job/21930810494

@thewilsonator thewilsonator merged commit 65db10c into dlang:stable Feb 24, 2024
46 checks passed
@ibuclaw ibuclaw deleted the gha_macos13_fixed branch February 24, 2024 08:43
@kinke
Copy link
Contributor

kinke commented Feb 24, 2024

Very nice! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants