Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Rationale to assert() specification #3307

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

WalterBright
Copy link
Member

This comes up now and then, it's nice to be able to point to the long discussions on it.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @WalterBright!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Copy link
Member

@mdparker mdparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer my suggested rewrite for the less casual language, but the two minor changes work, too.

spec/expression.dd Outdated Show resolved Hide resolved
@jmh530
Copy link
Contributor

jmh530 commented May 22, 2022

I would much rather a single simple explanation, with examples, and then the link to further discussion.

@aG0aep6G
Copy link
Contributor

This is an alarmingly low-effort and low-quality PR. A discussion thread with hundreds of messages of different authors displaying different opinions does not make a good rationale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants