Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relax restrictions on anchors/aliases to closer match current YAML spec #299

Merged
merged 1 commit into from
Aug 6, 2022

Conversation

Herringway
Copy link
Member

None of the YAML specs had the existing restrictions.

@codecov
Copy link

codecov bot commented Jul 25, 2022

Codecov Report

Merging #299 (57f8086) into master (68ceb0e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #299   +/-   ##
=======================================
  Coverage   95.17%   95.17%           
=======================================
  Files          29       29           
  Lines        4555     4559    +4     
=======================================
+ Hits         4335     4339    +4     
  Misses        220      220           
Impacted Files Coverage Δ
source/dyaml/emitter.d 95.39% <100.00%> (ø)
source/dyaml/scanner.d 99.65% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68ceb0e...57f8086. Read the comment docs.

@Herringway Herringway force-pushed the relaxed-anchor branch 2 times, most recently from 8f79c57 to 06d1594 Compare July 31, 2022 17:24
@Herringway
Copy link
Member Author

Now with proper tests and a little cleanup.

Copy link
Member

@Geod24 Geod24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one thing

source/dyaml/emitter.d Outdated Show resolved Hide resolved
@Geod24 Geod24 merged commit 0eb040e into dlang-community:master Aug 6, 2022
@Herringway Herringway deleted the relaxed-anchor branch August 6, 2022 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants