Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MarkedYAMLException#mark #278

Merged

Conversation

tom-tan
Copy link
Contributor

@tom-tan tom-tan commented Dec 26, 2021

This request adds MarkedYAMLException#mark.
It is useful for debugging and also enables users of D-YAML to make fine-grained error messages.

@codecov
Copy link

codecov bot commented Dec 26, 2021

Codecov Report

Merging #278 (c5fac9c) into master (a680555) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #278   +/-   ##
=======================================
  Coverage   95.99%   95.99%           
=======================================
  Files          28       28           
  Lines        4066     4068    +2     
=======================================
+ Hits         3903     3905    +2     
  Misses        163      163           
Impacted Files Coverage Δ
source/dyaml/exception.d 76.19% <100.00%> (+2.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a680555...c5fac9c. Read the comment docs.

Copy link
Member

@Herringway Herringway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, just one little nit to pick.

source/dyaml/exception.d Outdated Show resolved Hide resolved
@Herringway Herringway merged commit f7dc530 into dlang-community:master Dec 27, 2021
@tom-tan tom-tan deleted the add-MarkedYAMLException-mark branch December 27, 2021 05:28
@tom-tan
Copy link
Contributor Author

tom-tan commented Dec 27, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants