Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert logo image to svg #275

Merged
merged 3 commits into from
Oct 13, 2021

Conversation

asperan
Copy link
Contributor

@asperan asperan commented Oct 12, 2021

Hi, this PR fixes #167 by providing an svg file for the logo image. I tried to recreate the original logo as precise as I could.

I didn't delete the 2 old bitmap files to be sure to not break anything, but I have not found any place in the repository where it is used, so I can delete them if needed.

@Herringway
Copy link
Member

nice work! the ellipsis seems to be misplaced in my browser, though. it appears on top of the L instead of after it

@asperan
Copy link
Contributor Author

asperan commented Oct 12, 2021

That's strange, in my browser (Firefox) the logo appear to be correct:
DYAML_LOGO_VIEW

and in Inkscape I see the same:
DYAML_LOGO_INKSCAPE

but on my phone (using Firefox for android) it appears as you described:
DYAML_LOGO_PHONE

I have no clue about what could cause this behavior, maybe the browsers are rendering the svg file differently?

@Herringway
Copy link
Member

with chrome 94, the ellipsis is even further to the left. unfortunately, I don't know enough about SVG to have any idea about what's happening here. your work is excellent, so I hate to see technical issues getting in the way here...

@asperan
Copy link
Contributor Author

asperan commented Oct 13, 2021

I noticed that the font of the text (firstly the YAML part) is different between the two appearance, maybe it is the cause of the inconsistency.

Can you tell me if you see same the font I see on my pc or the font I see on my phone?

Meanwhile I'll try to fix this problem, somehow.

@asperan
Copy link
Contributor Author

asperan commented Oct 13, 2021

I converted texts into paths and shapes (mostly rectangles) as I suspect the problem was that I used a particular font which is not installed in Chrome nor Firefox for android, so the text wasn't rendered correctly.

Now the text part is just paths and shapes, so it is not dependent on the font.

Please, tell me if now you view the image correctly (now I see the correct image from my phone, but I prefer an external validation too :) )

@Herringway
Copy link
Member

looks perfect now! so it must've been different fonts... good to know for the future.

@Herringway Herringway merged commit ef96ff4 into dlang-community:master Oct 13, 2021
@Herringway
Copy link
Member

thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert DYAML logo to SVG
2 participants