Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes needed for coroutine support #13

Merged
merged 2 commits into from
Apr 2, 2018
Merged

Conversation

kennykb
Copy link

@kennykb kennykb commented Mar 30, 2018

Donal,

These are changes that we will need in order to have quadcode generate calls to the LLVM coroutine intrinsics. I'll follow up with details on the mailing list.

Kevin

Change log:
Silence many warnings when building with gcc.

Add 'ParseCommandLineOptions' to allow for changing unexported options
such as '-debug-pass'

Add 'addCoroutinePassesToExtensionPoints' so that generated code can
use LLVM coroutines.

kennykb added 2 commits March 30, 2018 15:17
Add 'ParseCommandLineOptions' to allow for changing unexported options
such as '-debug-pass'

Add 'addCoroutinePassesToExtensionPoints' so that generated code can
use LLVM coroutines.
@kennykb
Copy link
Author

kennykb commented Mar 30, 2018

D'oh! Need to advance the minor version to advertise the API change. Another commit made.

@dkfellows
Copy link
Owner

dkfellows commented Apr 2, 2018

Looks good; there's a few places where I'd do things a bit differently myself, but I tend to think that's not a reason for pushing back.

@dkfellows dkfellows merged commit 68aab05 into dkfellows:master Apr 2, 2018
@dkfellows
Copy link
Owner

dkfellows commented Apr 2, 2018

The changes that I needed on the end were:

  1. Added coroutines to the list of components. Some LLVM builds (those that use .a files) split themselves up into many libraries (“components”) and the coroutine support needed to be added for my system.
  2. Made the command line argument parser not keel the Tcl process over if it detects an error. It's up to the calling Tcl code to make that sort of decision.

Alas, I only detected the first issue after the merge (the second wasn't a build breaker).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants