Remove hardcoded quick instances

[Shinthoras0815]

This replaces the hardcoded selection of "QUICK" instances in the going_postal job (mad sorcerers in library) with a dynamic instance selection mechanism. This change allows modders to set their own custom "QUICK" instances.

[PieterVdc]

If I'm reading correctly now warlocks would start shooting navigating missiles at imps, doesn't sound like something we'd want

[walt253]

If I'm reading correctly now warlocks would start shooting navigating missiles at imps, doesn't sound like something we'd want

For reference this is what I did on a discontinued PR.

CrInstance get_best_quick_range_instance_to_use(const struct Thing *thing)
{
    struct InstanceInfo* inst_inf;
    for (int p = PRIORITY_MAX; p >= 0; p--)
    {
        for (int i = 0; i < game.conf.crtr_conf.instances_count; i++)
        {
            inst_inf = creature_instance_info_get(i);
            if (inst_inf->priority < p) // Instances with low priority are used last.
                continue;
            if (flag_is_set(inst_inf->instance_property_flags, InstPF_Quick))
            {
                INSTANCE_RET_IF_AVAIL(thing, i);
            }
        }
    }
    return CrInst_NULL;
}

It used a priority parameter and in case of ties it's the first instance on the list the creature uses first.

Shinthoras version is better in my opinion, it checks the range min/max (something I intentionnaly neglected since my reasoning was the vanilla experience don't check the range) and it adds some randomness to the mix.

[PieterVdc]

I'm not fond of the randomness part of choosing an instance, they're supposed to use something weak to scare them off so they'd leave, not intentionally murder them

[walt253]

I'm not fond of the randomness part of choosing an instance, they're supposed to use something weak to scare them off so they'd leave, not intentionally murder them

It still pick only those with the QUICK attribute, right?

They are not going to use Meteor unless mapmaker give it QUICK, I think?

Edit: maybe I'm missing your point entirely, that's possible too. 🤔

[PieterVdc]

navigating missile is in the current list, but not something I'd want warlocks to use if fireball is available

[walt253]

I think maybe we just want to keep QUICK on fireball and regular missile (for wizard)? So remove from all the others instances? I don't know, just an idea.